[TECH] arrêter d'utiliser les champs userId / snappedAt (Pix-17286) #11965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
added
the
⚠️ PR Inheritance
lionelB
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
de19255 to
fcaa381
Compare
lionelB
removed
the
⚠️ PR Inheritance
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
theotime2005
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
c13c00c to
77db09e
Compare
xav-car
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
55c92c2 to
3f4bbd7
Compare
xav-car
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
3f4bbd7 to
4d7f77a
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
lionelB
commented
Apr 7, 2025
| snapshot, | ||
| campaignParticipationId, | ||
| } = {}) { | ||
| const dateMinusOneDay = new Date(snappedAt.getTime() - 1000 * 60 * 60 * 24 * 7); | ||
| userId = _.isUndefined(userId) ? buildUser().id : userId; |
There was a problem hiding this comment.
thought: on peut conserver le userId pour la construction des knowledgeElement
lionelB
commented
Apr 7, 2025
| createdAt, | ||
| }); | ||
|
|
||
| databaseBuilder.factory.buildKnowledgeElementSnapshot({ |
There was a problem hiding this comment.
question : ce ke n'etait utilisé ?
There was a problem hiding this comment.
Vu que dans le contexte général, on ne teste que le nom du fichier d'export, ça faisait sens de ne pas placer la création de ke ici (ils sont toujours construits dans les autres contextes).
lionelB
commented
Apr 7, 2025
| 'campaign-participations.sharedAt', | ||
| ); | ||
| }) | ||
| .select('campaign-participations.id', 'campaign-participations.userId', 'campaign-participations.sharedAt') |
There was a problem hiding this comment.
question Est ce qu'on a encore besoin de ce script (on pourrait le supprimer si il n'est plus utile)?
There was a problem hiding this comment.
Je crois qu'on l'a laissé parce qu'il pourrait nous resservir
alicegoarnisson
added
Func Review OK
alicegoarnisson
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
657bd57 to
8b5056f
Compare
machestla
approved these changes
Apr 8, 2025
| if (!snapshot) { | ||
| const knowledgeElements = []; | ||
| knowledgeElements.push(buildKnowledgeElement({ userId, createdAt: dateMinusOneDay })); | ||
| knowledgeElements.push(buildKnowledgeElement({ userId, createdAt: dateMinusOneDay })); | ||
| userId = _.isUndefined(userId) ? buildUser().id : userId; |
There was a problem hiding this comment.
thought : avons nous besoin de lodash pour des questions de lisibilité ou est ce que l'écriture userId === undefined pourrait répondre au besoin ?
| @@ -1,6 +1,6 @@ | |||
| import _ from 'lodash'; | |||
|
|
|||
| import * as knowledgeElementSnapshotAPI from '../../../../../../src/prescription/campaign/application/api/knowledge-element-snapshots-api.js'; | |||
| import * as knowledgeElementSnapshotAPI from '../../../../../../src/prescription/campaign/application/api/knowledge-element-snapshots-api.js'; | |||
There was a problem hiding this comment.
thought: étonnant que cela ne titille pas le linter
alicegoarnisson
approved these changes
Apr 8, 2025
alicegoarnisson
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
…pation Co-Authored-By: alicegoarnisson <187311468+alicegoarnisson@users.noreply.github.com> Co-Authored-By: Xavier Carron <33637571+xav-car@users.noreply.github.com>
…ent-snapshots Co-Authored-By: alicegoarnisson <187311468+alicegoarnisson@users.noreply.github.com> Co-Authored-By: Xavier Carron <33637571+xav-car@users.noreply.github.com>
…pository Co-Authored-By: alicegoarnisson <187311468+alicegoarnisson@users.noreply.github.com> Co-Authored-By: Xavier Carron <33637571+xav-car@users.noreply.github.com> Co-Authored-By: Alexandre-Monney <101280231+Alexandre-Monney@users.noreply.github.com>
Co-authored-by: Théotime Berthod <theotime.berthod@pix.fr>
…pationId Co-authored-by: Théotime Berthod <theotime.berthod@pix.fr>
pix-service-auto-merge
force-pushed
the
pix-17286/stop-populate-userId-snappedAt
branch
from
8b5056f to
36b3db5
Compare
pix-service-auto-merge
deleted the
pix-17286/stop-populate-userId-snappedAt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Dans le cadre de la mise en conformité des données, On souhaite remplacer l'utilisation des champs
userIdetsnappedAtparcampaignParticipationId.🌳 Proposition
On arrête de peupler et d'utiliser les champs
userIdetsnappedAt🐝 Remarques
🤧 Pour tester
admin-orga@example.netpuis